cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpalermo <>
Subject [GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....
Date Sat, 19 Apr 2014 22:41:35 GMT
GitHub user jpalermo opened a pull request:

    Change private members to be protected

    We're modifying a plugin to use most of the Camera plugin behavior on Android, but we
want to override what happens inside of takePicture.
    takePicture uses a number of private members, so overriding it means we need to copy the
source for nearly everything into our subclass and then we loose a lot of the value we want
from inheriting from CameraLauncher.
    This changes all the members of CameraLauncher to be protected rather than private.

You can merge this pull request into a Git repository by running:

    $ git pull protected_members

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
commit 0974898636dfa217b77362d0c8e8d9088f37cf39
Author: Joseph Palermo <>
Date:   2014-04-18T17:41:12Z

    Change private members to be protected so inheritance is possible.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message