cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shortstuffsushi <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: Fix Beep exception on Android
Date Wed, 30 Apr 2014 15:11:14 GMT
GitHub user shortstuffsushi opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/20

    Fix Beep exception on Android

    In iOS, if you call the beep function and don't provide a count, it plays a single beep.
On Android, however, it always attempts to load the fix object in the array, which is null
if no count is provided, causes an exception to be thrown, and no beep to occur. The simplest
fix for this is to simply pass `1` if no count is provide from the web.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shortstuffsushi/cordova-plugin-dialogs patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit a1713d035a7f0456869585d0fb62f38ef590b08b
Author: Graham Mueller <graham.mueller315@gmail.com>
Date:   2014-04-30T15:10:59Z

    Fix Beep exception on Android
    
    In iOS, if you call the beep function and don't provide a count, it plays a single beep.
On Android, however, it always attempts to load the fix object in the array, which is null
if no count is provided, causes an exception to be thrown, and no beep to occur. The simplest
fix for this is to simply pass `1` if no count is provide from the web.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message