cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: Move e2e tests into spec overwriting dup...
Date Wed, 09 Apr 2014 19:41:47 GMT
GitHub user kamrik opened a pull request:

    https://github.com/apache/cordova-cli/pull/159

    Move e2e tests into spec overwriting duplicate tests.

    Merging e2e tests into spec/ dir and removing the old duplicate tests as discussed in
    https://www.mail-archive.com/dev@cordova.apache.org/msg15466.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kamrik/cordova-cli deleteSomeTests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit 0bcafb3fb77c4fe0616ad305c058929204f54e13
Author: Mark Koudritsky <kamrik@gmail.com>
Date:   2014-04-08T21:50:44Z

    CB-6421: Move tests from e2e to spec
    
    Removing the duplicate tests first as a separate commit (for better history).

commit bdf61422ba8f455b6e06c0d352c0a970fa431afd
Author: Mark Koudritsky <kamrik@gmail.com>
Date:   2014-04-08T22:27:54Z

    CB-6421: Move tests from e2e to spec
    
    Part 2, move all the files and delete e2e dir.
    For history of old overwritten tests in spec try
    git log 5cf9d9064005ff7bc6205c05277169b929e52fb5

commit f8cb94c58c229b840f402519e33585d833ecfc89
Author: Mark Koudritsky <kamrik@gmail.com>
Date:   2014-04-09T19:23:48Z

    CB-6421: Move tests from e2e to spec - cli test
    
    After e2e dir was merged into spec/ there were interferences between the e2e
    tests and cli.spec.js. Jasmine runs all tests in a single process, therefore
    process-global settings like event listener (un)registration can cause
    interference between the tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message