cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Soref <>
Subject Re: [DISCUSS] Automate signed icla to git commits
Date Wed, 30 Apr 2014 16:08:46 GMT
Jesse wrote:
> again:  I would rather leave the definition of 'trivial' to the reviewer
> the pull request.
> An update to docs of 100 lines can be trivial ... Josh renaming 'cordova'
> to 'Cordova' across 3 repos, and 15 files, could be considered trivial
> 4 lines of critical code could be non-trivial.
> Note, I am not calling out Josh, I am just making a more specific
> valuable and trivial are different things.

Nothing wrong with using me as an example of such things. I tend to cover
most interesting edge cases, so it's a good idea to check to see if any of
my actions are relevant edges that should be addressed.

View raw message