cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Sharing code between plugman and cordova-cli
Date Tue, 15 Apr 2014 21:41:23 GMT
I should have updated this email thread.  That proposal is old news, Mark
has done a writeup:
https://docs.google.com/document/d/1GVtG6BD266dqRURKaS-GEDefb0tBYt56acxrJEKAfmE/edit


(I know you have commented on it already, but for others)

On Tue, Apr 15, 2014 at 4:20 PM, Brian LeRoux <b@brian.io> wrote:

> >
> > I think everyone is on board with the idea that modules should be used to
> > enable sharing code, and for code organization.
> >
>
> Cool.
>
>
> > Two problems that are happening in practice:
> > - Multiple pull requests (plugman and CLI) to make a change
> > - Code duplication between the repositories
> >
> > Both of these are solved by moving all common code into the same git
> > repository.
> >
>
> Nope. Multiple pull requests to make a single functional change could be
> achieved by pulling a common module out. I respect you have a single repo
> at Google but this is not the solution to everything!
>
>
>
>
> > I think whether to make additional npm packages should happen as a
> > follow-up, and as concrete proposals (e.g. Let's publish CordovaError
> into
> > an npm package)
> >
>
> Sure
>
>
> It's a bit weird that a lot of cordova's CLI is in a module called
> > "cordova", but you need to install "plugman" to publish to the registry.
> >
>
> Nope. The choice to make the CLI the entry point for developers of cordova
> makes perfect sense. To have a separate tool for publishing also makes
> sense. Exposing that tool from Cordova was always the idea.
>
>
>
> > How about folding the functionality of plugman into cordova?
> >
>
> Right. This doesn't mean they have to be in the same git repo. In Cordova
> you can use package.json to include Plugman and expose functionality. This
> way you win versioning which is the point dependency management…not SCM.
>
>
> > For users that are accustomed to using plugman directly, we could make
> > plugman depend on CLI to have it continue working.
> >
>
> What?! Why!
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message