cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: [DISCUSS] Automate signed icla to git commits
Date Fri, 25 Apr 2014 19:31:32 GMT
Instead of having a map of username -> Real Name, we could maintain a list
of usernames that we know have a valid ICLA.

AUTHORs files might if we want to maintain them in every repo that we have.


On Fri, Apr 25, 2014 at 3:16 PM, Michal Mocny <mmocny@chromium.org> wrote:

> Yeah first thing that come to my mind was to just add it as part of the
> commit itself, so AUTHORS and/or COMMITTERS files.
>
> This means that we don't append anything with coho, we just do, git patch
> author -> lookup in AUTHORS -> get real name -> lookup in apache list
>
> We could even make a git commit (or maybe push?) hook to verify that AUTHOR
> is filled in properly, and warn about ICLA at that point?
>
> -Michal
>
>
> On Fri, Apr 25, 2014 at 3:03 PM, Ian Clelland <iclelland@chromium.org
> >wrote:
>
> > How about an AUTHORS file in (one|each) of the repos? They're usually
> > supposed to be human-readable, but it wouldn't take much to make it
> > machine-readable as well, and have coho output a list of new authors to
> vet
> > and append to it on each release.
> >
> >
> > On Fri, Apr 25, 2014 at 2:55 PM, Jesse <purplecabbage@gmail.com> wrote:
> >
> > > The automation of icla contributors being compared to commits was
> > mentioned
> > > in another thread[1].
> > >
> > > >> 3 - Code is made up of commits by individuals that have signed the
> > > >> ICLA (or that are trivial commits)
> > >
> > > I foresee issues as there are lots of cases where github usernames are
> > not
> > > easily compared to actual names. purplecabbage -> Jesse MacFadyen for
> > one!
> > >  In some cases github does not even contain the real name of the user.
> > >
> > > Maintaining a list would not only make this easy to automate, but it
> > would
> > > help anyone looking to accept a pull-req from having to vet the
> > > contributor.
> > >
> > > This would require a change to our contributor workflow, but how should
> > we
> > > do it? Some ideas.
> > > 1. Email to the dev list with a special subject ex. IAM
> Name->githubUser
> > > 2. add your info to a wiki page
> > > 3. add git username to the icla form ( not sure we can add to it )
> > > 4. when one of us vets someone, we add them to a private? list
> somewhere
> > > 5. ... ?
> > >
> > >
> > >
> > > [1] http://markmail.org/message/qyrvfae7ic526dgw
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message