cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fardjad <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...
Date Wed, 23 Apr 2014 21:11:41 GMT
Github user fardjad commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/164#discussion_r11924083
  
    --- Diff: src/metadata/android_parser.js ---
    @@ -97,6 +108,29 @@ module.exports.prototype = {
                 }
             }
     
    +        // Set launchMode in AndroidManifest
    +        var launchModePref = this.findLaunchModePreference(config);
    +        if (launchModePref) {
    +            var act = manifest.getroot().find('./application/activity');
    +            switch (launchModePref) {
    --- End diff --
    
    I agree, I could use an **if** statement. Will fix that in my next commit after we discuss
the [**default** case](https://github.com/apache/cordova-cli/pull/164#r11923593) a little
bit more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message