cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machenmusik <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...
Date Wed, 23 Apr 2014 18:42:39 GMT
Github user machenmusik commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41198810
  
    of course you wouldn't pull it in without understanding "why", but I would
    not ever expect reading the commit message alone to explain the "why".
     typically those details are in tracking systems (bugzilla, jira, whatever)
    and the backthread is far too long to jam into a commit message.
    
    as this particular commit spans multiple implementation languages, and IMO
    the reasons to add the capability to do other than multipart form upload
    file transfer should be obvious to the folks in charge of the file transfer
    component, the commit message simplifies the verification of actual diffs
    across the multiple implementations required by the current plugin
    structure, and also informs whoever handles updating documentation how it
    would be used.
    
    I understand how these multiplatform changes are a PITA to review :-)
    
    I don't think I have access to add a Cordova issue to link this to for
    tracking per your comments on "why", do you?
    
    
    On Wed, Apr 23, 2014 at 2:14 PM, Shazron Abdullah
    <notifications@github.com>wrote:
    
    > Of course "why" matters, especially to a committer (the code already is
    > "how"). There is absolutely no reason to add code that you don't understand
    > why you are adding it in the first place. To pull it in -- if I don't
    > understand it (I do now, of course) I would not pull it in.
    >
    > In any case, I haven't had time to fully review this, esp. the non-iOS
    > parts...
    >
    > —
    > Reply to this email directly or view it on GitHub<https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41195514>
    > .
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message