cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...
Date Wed, 23 Apr 2014 18:14:14 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41195514
  
    Of course "why" matters, especially to a committer (the code already is "how"). There
is absolutely no reason to add code that you don't understand why you are adding it in the
first place. To pull it in -- if I don't understand it (I do now, of course) I would not pull
it in. 
    
    In any case, I haven't had time to fully review this, esp. the non-iOS parts...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message