cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmocny <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...
Date Wed, 23 Apr 2014 17:07:59 GMT
Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/164#discussion_r11911266
  
    --- Diff: src/metadata/android_parser.js ---
    @@ -97,6 +108,29 @@ module.exports.prototype = {
                 }
             }
     
    +        // Set launchMode in AndroidManifest
    +        var launchModePref = this.findLaunchModePreference(config);
    +        if (launchModePref) {
    +            var act = manifest.getroot().find('./application/activity');
    +            switch (launchModePref) {
    +                case 'standard':
    +                    act.attrib["android:launchMode"] = 'standard';
    +                    break;
    +                case 'singleTop':
    +                    act.attrib["android:launchMode"] = 'singleTop';
    +                    break;
    +                case 'singleTask':
    +                    act.attrib["android:launchMode"] = 'singleTask';
    +                    break;
    +                case 'singleInstance':
    +                    act.attrib["android:launchMode"] = 'singleInstance';
    +                    break;
    +                case 'default':
    +                    delete act.attrib["android:launchMode"];
    --- End diff --
    
    This would delete the default from our application template, right?  I think we would
like to set a sensible default (thats the bug we fixed in the first place).
    
    However, an alternative way would be to leave this patch as-is and instead update defaults.xml
to include a default preference for this.  Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message