cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmocny <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-5833: Copy/link to custom merges and ...
Date Wed, 23 Apr 2014 13:35:34 GMT
Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/169#discussion_r11900004
  
    --- Diff: src/create.js ---
    @@ -124,9 +129,22 @@ module.exports = function create (dir, id, name, cfg) {
             }
             // Keep going into child "www" folder if exists in stock app package.
             while (fs.existsSync(path.join(www_lib, 'www'))) {
    +            www_parent_dir = www_lib;
                 www_lib = path.join(www_lib, 'www');
             }
     
    +        // Find if we also have custom merges and config.xml as siblings of custom www.
    +        if (www_parent_dir && config_json.lib && config_json.lib.www)
{
    +            custom_config_xml = path.join(www_parent_dir, 'config.xml');
    +            if ( !fs.existsSync(custom_config_xml) ) {
    +                custom_config_xml = '';
    --- End diff --
    
    I prefer null to empty string for these failure cases.  Empty string tests false in if
statements, but is a valid input for others.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message