cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <>
Subject [GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command
Date Wed, 23 Apr 2014 09:25:55 GMT
Github user martincgg commented on the pull request:
    I've been working on some other stuff with cordova-mobile-spec, but I came back to this
topic to deliver the pending changes removing callback functions, and use only promises and
superspawn following the recommendations and feedback provided.
    -Removed: All callbacks functions.
    -Every function returns a promise.
    -Use of superspawn instead of shelljs.
    -Use of Q.defer(), to resolve or reject promises.
    -Removed mostly all anonymous functions.
    It's cleaner and complexity has been reduced without promises-callbacks
    statements combination.
    Q.allSettled it will wait until all promises are resolved, and then write the log file,
collecting all data.
    @agrieve , thanks for the feedback and all the suggestions that you provided me. If this
is last commit is well accomplished, let me know to start to work on add support for blackberry,
wp8 and windows 8, using the same pattern.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message