cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Date Mon, 21 Apr 2014 16:47:19 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-40951040
  
    Thanks for this pull request. However, I have one comment, you need to use a weak reference
to self in the block. See:
    
    1. https://github.com/apache/cordova-plugin-contacts/blob/6ed8b906b78a445e0521d416fbc07d88987a0745/src/ios/CDVContacts.m#L78
    2. https://developer.apple.com/library/ios/documentation/cocoa/conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html#//apple_ref/doc/uid/TP40011210-CH8-SW16
    
    Also, you will need to sign the Apache iCLA before your contrib. can be pulled in: 
    https://www.apache.org/licenses/icla.txt



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message