cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...
Date Fri, 11 Apr 2014 16:14:51 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/161#discussion_r11539545
  
    --- Diff: src/superspawn.js ---
    @@ -24,6 +24,8 @@ var _ = require('underscore');
     var Q = require('q');
     var shell = require('shelljs');
     var events = require('./events');
    +var iswin32 = process.platform == 'win32';
    +var wrapcmd = iswin32 && require('os').release().split('.')[0] < 6;
    --- End diff --
    
    @martincgg: I was adding it because we _thought_ that there was something specific to
**XP**.
    
    I'd *rather* **not** have a specific code path for **XP** v. **7+**.
    
    I've pushed a refreshed patch which now provides something better.
    
    If @sgrebnov , @martincgg , @jengee could all test, that'd be great.
    
    I'm actually on vacation today and next week, but I'd still like to get this settled ASAP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message