cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...
Date Fri, 11 Apr 2014 15:28:53 GMT
Github user martincgg commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/161#discussion_r11537493
  
    --- Diff: src/superspawn.js ---
    @@ -24,6 +24,8 @@ var _ = require('underscore');
     var Q = require('q');
     var shell = require('shelljs');
     var events = require('./events');
    +var iswin32 = process.platform == 'win32';
    +var wrapcmd = iswin32 && require('os').release().split('.')[0] < 6;
    --- End diff --
    
    What do you need to determine with require('os').release().split('.')[0] < 6, I mean
what's the reason?
    If you need to get Windows OS info you can use: wmic, this command-line tool is available
in every Windows OS since Win XP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message