cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...
Date Fri, 11 Apr 2014 08:48:17 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/161#discussion_r11523476
  
    --- Diff: src/superspawn.js ---
    @@ -24,6 +24,8 @@ var _ = require('underscore');
     var Q = require('q');
     var shell = require('shelljs');
     var events = require('./events');
    +var iswin32 = process.platform == 'win32';
    +var wrapcmd = iswin32 && require('os').release().split('.')[0] < 6;
    --- End diff --
    
    I'm running Win8.1 and have the following os.release value: OS: 6.2.9200.
    So wrapcmd is False.
    But I can't still run non-exe files: Command finished with error code ENOENT:
    
    So I think this should be applied to all win platforms, isn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message