cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...
Date Thu, 10 Apr 2014 19:32:31 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/161#discussion_r11502884
  
    --- Diff: src/superspawn.js ---
    @@ -67,11 +69,11 @@ exports.spawn = function(cmd, args, opts) {
         var spawnOpts = {};
         var d = Q.defer();
     
    -    if (process.platform == 'win32') {
    +    if (iswin32) {
             cmd = resolveWindowsExe(cmd);
             // If we couldn't find the file, likely we'll end up failing,
             // but for things like "del", cmd will do the trick.
    -        if (!fs.existsSync(cmd)) {
    +        if (wrapcmd && path.extname(cmd) != '.exe' || !fs.existsSync(cmd)) {
    --- End diff --
    
    Opps, I see, thx @jsoref !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message