cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...
Date Tue, 08 Apr 2014 21:12:54 GMT
Github user martincgg commented on the pull request:

    https://github.com/apache/cordova-cli/pull/158#issuecomment-39902600
  
    I've tracked down this problem, and I've found the problem.
    The custom path in check_requirements function in blackberry10_parser.js, It looks for
a custom path, declared into the project, under .cordova/config.js and checks if exists any
match with blackberry10.
    When a blackberry library is cloned from Github.com, as 'cordova-blackberry', blackberry10
library is located under this cloned repository, I assume that this settlement is because
several blackberry platforms can be added here, as it is for 'cordova-windows' that contains
windows8 and 7, or as windows-phone that contains wp7 and wp8.
    Tracking this problem, I've found that lazy_load.js, joins the url and the platform subdirectory:
    https://github.com/apache/cordova-cli/blob/master/src/lazy_load.js#L63
    Therefore, the requirements check, it should be handle under the same conditions.
    
    Adding path.join, it only will add the custom_path + 'blackberry10' ---> lib name and
it will normalize the path as well.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message