cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bryanhiggins <...@git.apache.org>
Subject [GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
Date Mon, 07 Apr 2014 16:33:08 GMT
Github user bryanhiggins commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/154#discussion_r11352355
  
    --- Diff: blackberry10/bin/templates/project/cordova/lib/target-utils.js ---
    @@ -254,16 +254,15 @@ _self = {
                 };
     
             bb10_utils.exec(script, args, options, function (error, stdout, stderr) {
    -            // error code 3 corresponds to a connected device, null or "Error: null"
in stderr corresponds to connected emulator
    -            var isSimConnected = (type === "emulator" && (
    +            // error code 3 corresponds to connected device with password
    +            // null or "Error: null" in stderr corresponds to connected simulator or
device without password
    +            var connected =
                         error === null ||
    +                    (error && error.code === 3) ||
    --- End diff --
    
    In this case 'null' has a distinct value over 'undefined'. I'll update the comment to
make that clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message