cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command
Date Fri, 04 Apr 2014 16:38:17 GMT
Github user martincgg commented on the pull request:

    https://github.com/apache/cordova-cli/pull/151#issuecomment-39585091
  
    Last commit.
    -Removed functions: appendLog, writeLog, delLog.
    -No indent on top-level functions
    -Changed for loop from for(var t in promises) to
    promises.forEach(function(p))
    -Other minor changes
    
    Well @agrieve , this is what I got, I have a combination of callbacks and promises, trying
to take good advantages of both of them, you have more experience and expertise than me in
this subject, if you want me to change the whole thing to promises, just let me know, but
I rather focus efforts on in adding support to other platforms and make more improvements,
but like I said, if you consider that the best action to take is change the whole thing to
promises and not a combination of callbacks and promises, it's Ok, I'll do it.
    Thanks a lot again for your feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message