cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command
Date Thu, 03 Apr 2014 16:56:23 GMT
Github user martincgg commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/151#discussion_r11260908
  
    --- Diff: src/info-utils.js ---
    @@ -0,0 +1,58 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +    var cordova_util  = require('./util'),
    +        child_process = require('child_process'),
    +        path          = require('path'),
    +        fs            = require('fs'),
    +        _self;
    +
    +_self = {
    +    
    +    getNodeInfo: function( callback ){
    +        _self.execFunc('node', '--version', function(call){callback("Node version: "+call);});
    --- End diff --
    
    The main reason is the possibility of use this helper functions to be used by other js
files, if another process requires to get any relevant information provided by utils-info.js,
besides, I'm working improving and providing more information, and it would be better keep
it outside of info.js file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message