cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command
Date Wed, 02 Apr 2014 18:20:02 GMT
Github user martincgg commented on the pull request:

    https://github.com/apache/cordova-cli/pull/151#issuecomment-39364969
  
    Well, the feedback was attended thanks a lot, here's the new commit, this are the changes:
    -Added, proper indent (4 spaces).
    -Removed, trailing whitespace
    -Fixed, callbacks double assignation.
    - \r replaced by \n.
    
    Also, now it uses Q to work with callbacks, this time is going to return
    every value retrieve from the environment, all promises it will be
    called, those promises are callbacks data, Q.allSettled is going to call
    all of them, and then wait until every single one of them is fulfilled
    or rejected, then is going to print the data and save into a file.
    Adding this logic, it returns promises, and cleans the code of heavy
    nesting of callbacks.
    The only disadvantage, is that it requires to wait until everything is done to show it
in the screen, if it takes too much time retrieving the data, the user may think that the
terminal is frozen, which is unlikely. 
    
    @agrieve is this what you recommend me to do?
    
    https://github.com/martincgg/cordova-cli/blob/31ea565bac97a6f35c484cba3461fb726f24e07a/src/info.js#L42
    
    This is better?. Btw thanks a lot for the feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message