cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Grebnov (Akvelon)" <v-seg...@microsoft.com>
Subject RE: [GitHub] cordova-cli pull request: CB-2606 add icon support
Date Tue, 29 Apr 2014 17:39:39 GMT
The code has been merged to master branch: https://github.com/apache/cordova-cli/commit/bc86dc6d9d308b09a2161bc8e3629020c79bb1ed

Btw, as per Contribution Workflow[1] github pull request is a correct way to provide a fix.
Why the PR info has not been updated that the fix was applied? I realize that the github is
just the mirror, but how this is supposed to work?

[1] http://wiki.apache.org/cordova/IssueWorkflow 

Thx!
Sergey
-----Original Message-----
From: Parashuram Narasimhan (MS OPEN TECH) [mailto:panarasi@microsoft.com] 
Sent: Tuesday, April 29, 2014 10:18 AM
To: dev@cordova.apache.org
Subject: RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

Wanted to ping you folks on this PR - https://github.com/apache/cordova-cli/pull/166

-----Original Message-----
From: Axel Nennker [mailto:ignisvulpis@gmail.com]
Sent: Friday, April 18, 2014 12:05 AM
To: dev
Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

Thanks Sergey. I want cb-2606 to be fixed and would be happy if either PR is merged. I am
sorry that I had not more time to cleanup the history in my PR.
Thanks again.
I hope that a committer takes the time to review and merge it now that ApacheCon is over.
Axel
 Am 18.04.2014 00:16 schrieb "sgrebnov" <git@git.apache.org>:

> Github user sgrebnov commented on the pull request:
>
>     
> https://github.com/apache/cordova-cli/pull/126#issuecomment-40769236
>
>     Hi @AxelNennker, I'm just trying to get this merged ASAP so I've 
> opened a separate PR which constants the same changes but re-based and 
> could be merged. Feel free to close the new PR if you feel we should 
> better to complete organizing this one. Thx!
>
>     https://github.com/apache/cordova-cli/pull/166
>
>
> ---
> If your project is set up for it, you can reply to this email and have 
> your reply appear on GitHub as well. If your project does not have 
> this feature enabled and wishes so, or if the feature is enabled but 
> not working, please contact infrastructure at 
> infrastructure@apache.org or file a JIRA ticket with INFRA.
> ---
>
Mime
View raw message