Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of drkemp@google.com designates
 209.85.128.172 as permitted sender)
MIME-Version: 1.0
Sender: drkemp@google.com
In-Reply-To: 
 <CAMSbhBg0c+vGxBth9EBB8j1EKd5ER0Gsvf86pr8wcR5O1T4WXg@mail.gmail.com>
References: 
 <CAAzFgyhAZRs_FRX6rQV4uKD9+JPmnwdcDSwLgZ=d=EV6TAdUDw@mail.gmail.com>
	<CAAzFgyikVj+anCS0XkCa7HTv-sL3i-a75kjaTYK88JPqFhKUmA@mail.gmail.com>
	<CF587203.109D5%jsoref@blackberry.com>
	<CABiQX1XPo1G+dhbEP-QiOx-9hLUhw9bQtJw=fhhSpODZo95pBg@mail.gmail.com>
	<CAMSbhBg0c+vGxBth9EBB8j1EKd5ER0Gsvf86pr8wcR5O1T4WXg@mail.gmail.com>
Date: Fri, 28 Mar 2014 09:07:27 -0400
Message-ID: 
 <CAMTxO40umtbvs0fL+5QCNHbQt1ywuYKPg=StWKTT2a3oo3USig@mail.gmail.com>
Subject: Re: Many CLI tests failing
From: David Kemp <drkemp@chromium.org>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a11337e042dc41d04f5aa621a

--001a11337e042dc41d04f5aa621a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I have just verified the plugman state and on my machine I get the same 7
errors that Medic gets.
All of them are related to version comparisions.


On Thu, Mar 27, 2014 at 6:17 PM, Steven Gill <stevengill97@gmail.com> wrote=
:

> All tests seem to be passing now.
>
> Medic is showing plugman tests failing after the tizen commits, but they
> are passing fine for me.
>
>
> On Wed, Mar 26, 2014 at 10:05 AM, Andrew Grieve <agrieve@chromium.org
> >wrote:
>
> > On Wed, Mar 26, 2014 at 9:05 AM, Josh Soref <jsoref@blackberry.com>
> wrote:
> >
> > > https://github.com/blackberry/cordova-cli/tree/cb_6337
> > >
> > > Should cover both of my breaks.
> > >
> > > I=C2=B9m waiting for our CI tooling to confirm it=C2=B9s happy before=
 I submit a
> > > pull request for it.
> > >
> > > Maybe sometime in the near future I=C2=B9ll try to rework the tests t=
o use
> an
> > > in-memory-psuedo-filesystem so that we can stop having to add all the=
se
> > > stupid lies.
> > >
> > > Tests shouldn=C2=B9t be so brittle that changing code which has no re=
lation
> to
> > > a test results in a broken test. If we=C2=B9re lying and pretending t=
hat
> > > there=C2=B9s e.g. a "lib/dir", then that directory needs to sufficien=
tly
> exist
> > > =E2=80=B9 adding code which makes a perfectly reasonable assumption =
=C2=B3this
> > > directory which someone claimed exists exists=C2=B2 shouldn=C2=B9t br=
eak a test
> > > which pretended the directory existed.
> > >
> >
> > Agree 100% with your sentiments here, and also agree that an in-memory
> > filesystem is the best way to make our tests decent.
> >
> > >
> > > The CordovaError bit is different (and entirely my fault), I think I
> must
> > > have failed to commit the requires update, because I remember doing t=
he
> > > greps for it...
> > >
> > >
> >
>

--001a11337e042dc41d04f5aa621a--