Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33F1110CA7 for ; Wed, 26 Mar 2014 16:05:07 +0000 (UTC) Received: (qmail 70878 invoked by uid 500); 26 Mar 2014 16:05:06 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 70792 invoked by uid 500); 26 Mar 2014 16:05:04 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 70784 invoked by uid 99); 26 Mar 2014 16:05:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Mar 2014 16:05:04 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jorge.torres.maldonado@gmail.com designates 209.85.128.182 as permitted sender) Received: from [209.85.128.182] (HELO mail-ve0-f182.google.com) (209.85.128.182) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Mar 2014 16:05:00 +0000 Received: by mail-ve0-f182.google.com with SMTP id jw12so2637153veb.13 for ; Wed, 26 Mar 2014 09:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=/dmj0Wf1PJGGBmGDy9oAY8gGIRPZkU7unklLN5iSzqE=; b=ydwPFcW0u2cqOeRM7yflFBsws5UuEwmS75heNTH0vAcey03VeUVzv/tRQQLbBS/5QV kiTjTelaJppAP+dJqIyvObdiJo7PV4qdmpXCcQYK4D9tC1PmmU94vKgcG8cYjTh6JxRI +nMxbfjJPCWY0dEJvTmaS91wDcgIfONykoLM9M91X+y4hClD15isfItaUK6fqiE+ktyH mVjL9n62kF0vAF7xdbxeeS5oUB9szQVzF0d3wzhUSvpWpDPMhia57ix5xrqHFNT+1Bnq N5OimoCobjNDm56HqVAtHH36UWcjby70Gc60WwxSKm9pr2qbOLeetZVYMgu60TwaMab9 Lzjg== X-Received: by 10.52.173.165 with SMTP id bl5mr42871307vdc.13.1395849879411; Wed, 26 Mar 2014 09:04:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.221.43.202 with HTTP; Wed, 26 Mar 2014 09:04:19 -0700 (PDT) In-Reply-To: References: From: Jorge Torres Date: Wed, 26 Mar 2014 12:04:19 -0400 Message-ID: Subject: Re: Intro and multithread calls - file-transfer in particular To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=bcaec51b9cfd38e27004f584a0e7 X-Virus-Checked: Checked by ClamAV on apache.org --bcaec51b9cfd38e27004f584a0e7 Content-Type: text/plain; charset=ISO-8859-1 Done, Thank you :) On Wed, Mar 26, 2014 at 11:20 AM, Andrew Grieve wrote: > Hi Jorge, > > Best way to propose a change is to use a github pull request against the > relevant repository. E.g. > https://github.com/apache/cordova-plugin-file-transfer > > > On Wed, Mar 26, 2014 at 7:59 AM, Jorge Torres < > jorge.torres.maldonado@gmail.com> wrote: > > > Dear all, > > > > My name is Jorge Torres, I love cordova! been using it for 3 years now. > > I would like to contribute. > > > > I have been getting warnings of filetransfer taking too long, its a quick > > fix to make that happen on a separate thread. > > > > I dont know how to request commit changes, but I attach the an IOS > patched > > file CDVFileTransfer.m for the download call. > > > > I simply modified download method (line 365) by routing the call to a new > > thread. > > > > I do wonder now, in most cases sending the CDVInvokes to another thread > is > > ideal, do you guys think we should work on a general solution for this. > > > > One last question: lf I wanted to request commits directly how can I do > > that. > > > > Jorge > > > > > > > --bcaec51b9cfd38e27004f584a0e7--