Return-Path: 
 <dev-return-31258-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3C76910385
	for <apmail-cordova-dev-archive@www.apache.org>;
 Thu, 27 Mar 2014 15:53:04 +0000 (UTC)
Received: (qmail 44042 invoked by uid 500); 27 Mar 2014 15:53:02 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 43997 invoked by uid 500); 27 Mar 2014 15:53:01 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 43986 invoked by uid 99); 27 Mar 2014 15:53:00 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2014 15:53:00 +0000
X-ASF-Spam-Status: No, hits=1.5 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of ignisvulpis@gmail.com
 designates 209.85.213.53 as permitted sender)
Received: from [209.85.213.53] (HELO mail-yh0-f53.google.com) (209.85.213.53)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2014 15:52:55 +0000
Received: by mail-yh0-f53.google.com with SMTP id v1so3746446yhn.40
        for <dev@cordova.apache.org>; Thu, 27 Mar 2014 08:52:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=ft7c1KJe/FBQkn2w8IjPNN+atXlslgpHCXqdAseExO0=;
        b=l947NPW1KJQfxb4M0G7OSPjwWTgBapQ6H5q9SPKyTWorGb7+QM0JDnKHovi9QySEu9
         efy7p8c4KQagYDcghLOWBcgQKDx68dA9XLE5yZL+TRo3KM058xieau2ZeoEDE/chhu9K
         Q8QGTGyecZxIpaNAL/l9KNr3D4rrF4TmmA0Ks73Ju6bPwzVTqbJ5c1XAAI8G0he0eLVC
         hJcGZCHlXnXw7TnpXGIK0d/TEdvFiaJa7rJArIbYYU3nQRi/lyUJlFQ2hezsV72POhfJ
         3j4uOXExpY7qAPMtp4gEk5rI2Djqo/kmkrkCW4+JEIbxOIBkLnbBbwdQkNOgmoPdEhhj
         nKHQ==
MIME-Version: 1.0
X-Received: by 10.236.61.45 with SMTP id v33mr3549507yhc.20.1395935553396;
 Thu, 27 Mar 2014 08:52:33 -0700 (PDT)
Received: by 10.170.114.71 with HTTP; Thu, 27 Mar 2014 08:52:33 -0700 (PDT)
In-Reply-To: <20140319172152.642EB9848BF@tyr.zones.apache.org>
References: <git-pr-126-cordova-cli@git.apache.org>
	<20140319172152.642EB9848BF@tyr.zones.apache.org>
Date: Thu, 27 Mar 2014 16:52:33 +0100
Message-ID: 
 <CAHcDwFyif2YCKPWTxfoW+PBLxnkfvRWv65gxwQfkxe5-muBGJg@mail.gmail.com>
Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support
From: Axel Nennker <ignisvulpis@gmail.com>
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=089e0160a73cca27b404f5989297
X-Virus-Checked: Checked by ClamAV on apache.org

--089e0160a73cca27b404f5989297
Content-Type: text/plain; charset=ISO-8859-1

any comments on this method/implementation?
Wishes for an alternative implementation?

I know that not all like the "guessing" part...


Axel

maybe this is liked by more of you?:

config.xml
<icon src="some/path/icon.png"> // iconpath=some/path and iconname=icon.png
would lead to this pseudocode implementation on Android:

for (dir in res/drable-*)  { // e.g. dir=drawable-hdpi
 if (fs.exists(path.join(iconpath,dir,iconname)) {
  copy path.join(iconpath,dir,iconname) to path.join("res", dir, icon.png)
// target is always named icon.png
 }
}

So if the developer wants an launcher icon then he has to put an icon.png
into e.g.
  some/path/drawable-hdpi/icon.png





2014-03-19 18:21 GMT+01:00 AxelNennker <git@git.apache.org>:

> Github user AxelNennker commented on the pull request:
>
>     https://github.com/apache/cordova-cli/pull/126#issuecomment-38080759
>
>     Re-implemented the "magic" for android. Typical sizes on Android are
> recognized and used. A default icon is copied to all res/drawable-*/
> directories.
>     A simple way to get launcher icons without xml namespace juggling or
> custom element in config.xml.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

--089e0160a73cca27b404f5989297--