Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of mmocny@google.com designates
 209.85.128.169 as permitted sender)
MIME-Version: 1.0
Sender: mmocny@google.com
In-Reply-To: 
 <CAEeF2TdQPWDRrhJ0-c0yMyvOmx-8KUW16LYJJfs9fNWiiG2Rfg@mail.gmail.com>
References: 
 <CAOBL_k5tWmagyzyOHFU1yJjNp8L7HRggbCxOkDDzdaeDKSuKmg@mail.gmail.com>
 <CABiQX1VpxhcTbyZJ2dpgsyN6wvp3z694dCnUtZm9t3_D7wyTug@mail.gmail.com>
 <CAEeF2TdQPWDRrhJ0-c0yMyvOmx-8KUW16LYJJfs9fNWiiG2Rfg@mail.gmail.com>
From: Michal Mocny <mmocny@chromium.org>
Date: Wed, 5 Mar 2014 23:59:52 -0500
Message-ID: 
 <CAEeF2Teqdja+nenS91oBv0QoqypS4_sNNDpfN+4v7isxVO894g@mail.gmail.com>
Subject: Re: [Android] Refactoring for different engines
To: Michal Mocny <mmocny@chromium.org>
Cc: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a1136988422fd4a04f3e9031f

--001a1136988422fd4a04f3e9031f
Content-Type: text/plain; charset=UTF-8

https://github.com/crosswalk-project/crosswalk-cordova-android

First patch they landed, which claims to have min viable xwalk webview:
https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04


On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mmocny@chromium.org> wrote:

> I haven't looked yet, but did you see:
> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>
> ?
>
>
> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>
>> First - very excited that you're working on this!
>>
>> Had a quick look. Not sure there's much to be gleaned yet. Once you start
>> in on hooking up x-walk's webview I think it will become more obvious what
>> the interface should look like. E.g., does x-walk even have the concept of
>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
>> should extend android.View as well as implement our interface. E.g.
>> alternative is to have a "getView()" method on the interface. Might help
>> to
>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>
>> I've been pretty hesitant to touch existing exposed members (e.g. the
>> public fields you were referring to) since touching anything public could
>> break plugins. That said, maybe now is a good time to @deprecate a bunch
>> of
>> them and either replace them with getters, or just declare them to be not
>> exposed to plugins.
>>
>>
>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bowserj@gmail.com> wrote:
>>
>> > So, after looking at the Crosswalk code again, I've decided to take a
>> > quick stab at making things pluggable.  I don't have a lot to show for
>> > it, but with the help of Eclipse (which is why the generated
>> > interfaces look so screwed up), I managed to create some interfaces so
>> > we can start shoehorning in other browser renderers.
>> >
>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>> >
>> > I'm going to probably start with Crosswalk, because it's probably the
>> > most mature primary candidate in the Android Third-Party WebView
>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>> > after.
>> >
>> > I don't know how this would work w.r.t. the CLI or our workflow at
>> > all, but at the moment, I really just want to at least start to have
>> > some headway towards 4.x and PhoneGap day.
>> >
>> > What do people think of this so far? I'm going to try to clean things
>> > up a bit, since we've definitely done a lot of things that would make
>> > first year CS profs freak the hell out (i.e. public members in public
>> > objects w.r.t. PluginManager).
>> >
>> > Thoughts?
>> >
>> > Joe
>> >
>>
>
>

--001a1136988422fd4a04f3e9031f--