Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F2E610A79 for ; Wed, 26 Mar 2014 15:21:09 +0000 (UTC) Received: (qmail 56518 invoked by uid 500); 26 Mar 2014 15:21:08 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 56488 invoked by uid 500); 26 Mar 2014 15:21:07 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 56478 invoked by uid 99); 26 Mar 2014 15:21:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Mar 2014 15:21:06 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates 209.85.192.180 as permitted sender) Received: from [209.85.192.180] (HELO mail-pd0-f180.google.com) (209.85.192.180) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Mar 2014 15:21:02 +0000 Received: by mail-pd0-f180.google.com with SMTP id v10so2021033pde.11 for ; Wed, 26 Mar 2014 08:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=Ivw1SSOKL59kUztxS2EP1H+O5ygdFhCPTs++qGU0Zxc=; b=QuQmjaNuwPghd5edQaIUU0MoDEdhrRmaQLWPJZVilw6HkCXmE8CtmViNjBQ0qOCowV 2yCMtExFcWGxd+J9jgQbMA+lrQnRskTMm1kqqmkHs4o52u5iMS6jkTu7vjF8j4GXHzAt HTZGQ5mmxafvf0P2TVwVRCIYAeZmh7xiqhKohAZ6vQ3hhW2gscyrDq26JKmGGYDKjwL4 oLefBgi63ZZ7/k3fXIcgcUzQh7bwnczg2VvhQ0v1H5ke3uP2IcqfgDnAf9IDTb/R4OSK RsHlTVJZJXI7x14MxVfQTvmgptIGTXatlHil8OKEPSiKOR9ah6/GffnH7cIjnprqtSuH ysGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=Ivw1SSOKL59kUztxS2EP1H+O5ygdFhCPTs++qGU0Zxc=; b=Caj9wvVR/mgvRdcyomfzs2uoTnnEr66fLzsMe2hfBsNCJY/QigaSYmELGQDh/iv8N/ Nvowf4LX/6/hbS/Mgbf0EwQIvCg+TlkSEVW6WwmeELHnMtqPoi/HcZowRl4mpnDAPpA8 /K7vmcoaub5+886I8GpxxTDmdRx+gnDL00BEI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:content-type; bh=Ivw1SSOKL59kUztxS2EP1H+O5ygdFhCPTs++qGU0Zxc=; b=BG5o4nSjx0UVLWuTgFReBEgvEtPOakPlXF0pNe4DYc0f8PMsahWUjCf3I3yyXRy61u PbOcSYXnF8hBYEI1YxiOPKh38cFqllL7Jl2ZvyQeYTcL33IceOJpGOc6a/hT1Z8Gwj3k TewuBOVekee7/3vb6AVaMOyoyrHBeZ1R8xsQ1MIbqKggOsj1hdolqTNlIO9ssJmSijB1 M86f/T2AsCYiXIBXiz9g2unj3MPHyHvulWqESvW+ggXj2KYh8MEfqAyjZrNHW/kTCjqo fX3L7DYEc1hkPcCIxc+K/de/mYiavn4atcdDkPdQA3iLGrprmfc4SYmD5RViylvXT8fg vdGw== X-Gm-Message-State: ALoCoQkPio0Zc6OL60sT7lZ7XLQOSu6atmwl872rmt6OBQhB+scInhZiw3EokbUGcF0fsmgl5t5M8Hu7xxAAljEofzROYRcnFPXiB3LQhUH2XuADnMHMW2pYQeKnuatcNrOtm4W4OMNXM3QF5pJi7XO4PzwlbZlUt2RuH2esjL8I6G5Y8zlGTnrSpDAhCKLMc42n1C2FtSJkiyCVWHTTYbkUV6nBSd1wOQ== X-Received: by 10.68.76.68 with SMTP id i4mr87673583pbw.73.1395847242372; Wed, 26 Mar 2014 08:20:42 -0700 (PDT) MIME-Version: 1.0 Sender: agrieve@google.com Received: by 10.68.127.133 with HTTP; Wed, 26 Mar 2014 08:20:21 -0700 (PDT) In-Reply-To: References: From: Andrew Grieve Date: Wed, 26 Mar 2014 08:20:21 -0700 X-Google-Sender-Auth: uuEYjaLVuQ-sBYh4u5eZzHbBh34 Message-ID: Subject: Re: Intro and multithread calls - file-transfer in particular To: dev Content-Type: multipart/alternative; boundary=e89a8f923df20af06e04f5840349 X-Virus-Checked: Checked by ClamAV on apache.org --e89a8f923df20af06e04f5840349 Content-Type: text/plain; charset=UTF-8 Hi Jorge, Best way to propose a change is to use a github pull request against the relevant repository. E.g. https://github.com/apache/cordova-plugin-file-transfer On Wed, Mar 26, 2014 at 7:59 AM, Jorge Torres < jorge.torres.maldonado@gmail.com> wrote: > Dear all, > > My name is Jorge Torres, I love cordova! been using it for 3 years now. > I would like to contribute. > > I have been getting warnings of filetransfer taking too long, its a quick > fix to make that happen on a separate thread. > > I dont know how to request commit changes, but I attach the an IOS patched > file CDVFileTransfer.m for the download call. > > I simply modified download method (line 365) by routing the call to a new > thread. > > I do wonder now, in most cases sending the CDVInvokes to another thread is > ideal, do you guys think we should work on a general solution for this. > > One last question: lf I wanted to request commits directly how can I do > that. > > Jorge > > > --e89a8f923df20af06e04f5840349--