Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: jsoref <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-66-cordova-plugman@git.apache.org>
In-Reply-To: <git-pr-66-cordova-plugman@git.apache.org>
Subject: [GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests
 & met...
Content-Type: text/plain
Message-Id: <20140320225915.9C50B9870EA@tyr.zones.apache.org>
Date: Thu, 20 Mar 2014 22:59:15 +0000 (UTC)

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugman/pull/66#discussion_r10821082
  
    --- Diff: spec/install.spec.js ---
    @@ -348,13 +349,58 @@ describe('install', function() {
                     runs(function () {
                         installPromise( install('android', project, plugins['G']) );
                     });
    -                waitsFor(function () { return done; }, 'install promise never resolved', 500);
    +                waitsFor(function () { return done; }, 'install promise never resolved', 200);
                     runs(function () {
                         var install = common.spy.getInstall(emit);
            
                         expect(done.message).toEqual('Cyclic dependency from G to H');
                     });
    -            });				
    +            });	
    --- End diff --
    
    This introduces trailing whitespace. Please don't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---