Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: jsoref <git@git.apache.org>
To: callback-dev@incubator.apache.org
Reply-To: callback-dev@incubator.apache.org
References: <git-pr-44-cordova-mobile-spec@git.apache.org>
In-Reply-To: <git-pr-44-cordova-mobile-spec@git.apache.org>
Subject: [GitHub] cordova-mobile-spec pull request: [firefoxos] CB-3208 Added
 suppor...
Content-Type: text/plain
Message-Id: <20140310203231.5A66B93D988@tyr.zones.apache.org>
Date: Mon, 10 Mar 2014 20:32:31 +0000 (UTC)

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10448723
  
    --- Diff: autotest/tests/contacts.tests.js ---
    @@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)", function () {
              });
             // HACK: there is a reliance between the previous and next test. This is bad form.
             it("contacts.spec.21 update a contact", function() {
    -
                 // this api requires manual user confirmation on WP7/8 so skip it
                 if (isWindowsPhone) return;
     
    -            expect(gContactObj).toBeDefined();
    +            var bDay = new Date(1976, 6,4);
    --- End diff --
    
    You "moved" a rather similar line:
    372      -            var bDay = new Date(1975, 5,4);
    to:
      381    +            var bDay = new Date(1976, 6,4);
    
    I assumed it was a straightforward move (I was too lazy to verify that it wasn't a straightforward move).
    I wanted to acknowledge that I was aware that your source didn't have good style -- i.e. it wasn't precisely your fault that there was a space missing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---