cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hadeslee <...@git.apache.org>
Subject [GitHub] cordova-android pull request: AlertDialog.Builder.create is reduda...
Date Fri, 21 Mar 2014 04:06:47 GMT
GitHub user hadeslee opened a pull request:

    https://github.com/apache/cordova-android/pull/96

    AlertDialog.Builder.create is redudant

    because AlertDialog.Builder.show() will create an AlertDialog before  it show.This is
the source code snippet:
    
            /**
             * Creates a {@link AlertDialog} with the arguments supplied to this builder and
             * {@link Dialog#show()}'s the dialog.
             */
            public AlertDialog show() {
                AlertDialog dialog = create();
                dialog.show();
                return dialog;
            }

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hadeslee/cordova-android patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 18b924d3f8fc8f8164792ada5ae6b9da21e4a3fa
Author: hadeslee <hadeslee@vip.qq.com>
Date:   2014-03-21T04:06:23Z

    AlertDialog.Builder.create is redudant
    
    because AlertDialog.Builder.show() will create an AlertDialog before  it show.This is
the source code snippet:
    
            /**
             * Creates a {@link AlertDialog} with the arguments supplied to this builder and
             * {@link Dialog#show()}'s the dialog.
             */
            public AlertDialog show() {
                AlertDialog dialog = create();
                dialog.show();
                return dialog;
            }

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message