cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhurliman <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...
Date Sat, 29 Mar 2014 07:05:41 GMT
GitHub user jhurliman opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/20

    Make dest NATIVE_URI compatible with source CAMERA

    When using the camera in iOS, UIImagePickerControllerReferenceURL does not exist because
the image only exists in memory immediately after taking a photo. This waits for the image
to be written to disk before firing the JS callback when Camera.SourceType.CAMERA, Camera.DestinationType.NATIVE_URI,
and saveToPhotoAlbum=true are used together in iOS.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jhurliman/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit 893466c7a9e45fd1772a9a5c9006d7856076c4b4
Author: John Hurliman <jhurliman@jhurliman.org>
Date:   2014-03-29T07:05:35Z

    Make dest NATIVE_URI compatible with source CAMERA
    
    When using the camera in iOS, UIImagePickerControllerReferenceURL does not exist because
the image only exists in memory immediately after taking a photo. This waits for the image
to be written to disk before firing the JS callback when Camera.SourceType.CAMERA, Camera.DestinationType.NATIVE_URI,
and saveToPhotoAlbum=true are used together in iOS.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message