cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jorge Torres <jorge.torres.maldon...@gmail.com>
Subject Re: Intro and multithread calls - file-transfer in particular
Date Wed, 26 Mar 2014 16:04:19 GMT
Done,

Thank you :)


On Wed, Mar 26, 2014 at 11:20 AM, Andrew Grieve <agrieve@chromium.org>wrote:

> Hi Jorge,
>
> Best way to propose a change is to use a github pull request against the
> relevant repository. E.g.
> https://github.com/apache/cordova-plugin-file-transfer
>
>
> On Wed, Mar 26, 2014 at 7:59 AM, Jorge Torres <
> jorge.torres.maldonado@gmail.com> wrote:
>
> > Dear all,
> >
> > My name is Jorge Torres, I love cordova! been using it for 3 years now.
> > I would like to contribute.
> >
> > I have been getting warnings of filetransfer taking too long, its a quick
> > fix to make that happen on a separate thread.
> >
> > I dont know how to request commit changes, but I attach the an IOS
> patched
> > file CDVFileTransfer.m for the download call.
> >
> > I simply modified download method (line 365) by routing the call to a new
> > thread.
> >
> > I do wonder now, in most cases sending the CDVInvokes to another thread
> is
> > ideal, do you guys think we should work on a general solution for this.
> >
> > One last question: lf I wanted to request commits directly how can I do
> > that.
> >
> > Jorge
> >
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message