cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Nennker <ignisvul...@gmail.com>
Subject Re: [GitHub] cordova-cli pull request: CB-2606 add icon support
Date Thu, 27 Mar 2014 15:52:33 GMT
any comments on this method/implementation?
Wishes for an alternative implementation?

I know that not all like the "guessing" part...


Axel

maybe this is liked by more of you?:

config.xml
<icon src="some/path/icon.png"> // iconpath=some/path and iconname=icon.png
would lead to this pseudocode implementation on Android:

for (dir in res/drable-*)  { // e.g. dir=drawable-hdpi
 if (fs.exists(path.join(iconpath,dir,iconname)) {
  copy path.join(iconpath,dir,iconname) to path.join("res", dir, icon.png)
// target is always named icon.png
 }
}

So if the developer wants an launcher icon then he has to put an icon.png
into e.g.
  some/path/drawable-hdpi/icon.png





2014-03-19 18:21 GMT+01:00 AxelNennker <git@git.apache.org>:

> Github user AxelNennker commented on the pull request:
>
>     https://github.com/apache/cordova-cli/pull/126#issuecomment-38080759
>
>     Re-implemented the "magic" for android. Typical sizes on Android are
> recognized and used. A default icon is copied to all res/drawable-*/
> directories.
>     A simple way to get launcher icons without xml namespace juggling or
> custom element in config.xml.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message