cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Nennker <ignisvul...@gmail.com>
Subject Re: [GitHub] cordova-cli pull request: CB-2606 add icon support
Date Thu, 27 Mar 2014 17:35:35 GMT
This pull request intentionally does not extend the w3c widget standard.
There is no cdv:platform nor gap:platform nor any XML namespace used.
 Am 27.03.2014 18:01 schrieb "cmarcelk" <git@git.apache.org>:

> Github user cmarcelk commented on the pull request:
>
>     https://github.com/apache/cordova-cli/pull/126#issuecomment-38831161
>
>     In a broad sense this looks reasonable.
>
>     In the config.xml, why is there width and height attributes when using
> cdv:platform="android" and cdv:density="mdpi"? Is hope to reuse the same
> <icon> element for iOS and other non-Android platforms? But doing so
> doesn't seem like it is meant to be compatible with cdv:platform="android".
> Or is it meant to be an alternate way of specifying cdv:density="mdpi" in
> the Android case?
>
>     I don't see where your code uses the "id" attribute in the <icon>
> element. What is that element supposed to do? And what happens when it's
> not present in the <icon> element?
>
>     It would be great to see some corresponding docs for this (i.e.,
> cordova-docs). Those docs would describe from the end-users view how they
> would consume this new capability.
>
>     When it inevitably comes time to do this for splash screens, will this
> icon approach work for splash screens?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message