cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: [GitHub] cordova-plugin-file-transfer pull request: Upload progress needs t...
Date Mon, 10 Mar 2014 03:32:14 GMT
GitHub Integration!!  Huzzah!


On Sat, Mar 8, 2014 at 4:36 PM, mhujer <git@git.apache.org> wrote:

> GitHub user mhujer opened a pull request:
>
>     https://github.com/apache/cordova-plugin-file-transfer/pull/23
>
>     Upload progress needs to be fixed for second file
>
>     Sent bytes must be reseted before new upload, otherwise "onprogress"
> event "loaded" value provides sum of uploaded bytes (not just for the
> current upload, but all of them).
>     This PR fixes the issue for me, but there is additional work necessary:
>     - check if this does not break anything
>     - check if it works for file downloading (I'm not using it myself).
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/mhujer/cordova-plugin-file-transferwp8-loaded
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/cordova-plugin-file-transfer/pull/23.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #23
>
> ----
> commit 70463c238aa3668c133cbfe88fe4646b1c46a4a6
> Author: Martin Hujer <mhujer@gmail.com>
> Date:   2014-03-08T21:33:37Z
>
>     Upload progress now works also for second file
>
>     - Sent bytes must be reseted before new upload, otherwise "onprogress"
> event "loaded" value provides sum of uploaded bytes (not just for the
> current upload, but all of them)
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message