cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lorin Beer <lorin.beer....@gmail.com>
Subject Re: Many CLI tests failing
Date Wed, 26 Mar 2014 17:01:46 GMT
Thanks Max,

took a look, some tests for functionality that isn't implemented made it
into master. I've reverted the offending change.

As policy, I'm behind reverting any commit that fails tests or breaks
functionality. It pollutes everyone's dev process with issues that should
remain isolated. I say this as one of the guilty parties this time.


- Lorin


On Tue, Mar 25, 2014 at 6:36 PM, Max Woghiren <maxw@chromium.org> wrote:

> Josh is having trouble accessing the buildbot page, so here is the
> relevant information.
>
> Lorin's relevant commit:
>
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=79e571953c2d3459b459c02eb50e753308fd453d
>
> Josh's relevant commits:
>
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=07181e4ee3e358b7af7674a4ae68fe06552b2655(platform
parsers)
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=edecaf9193e8b23c6b7e209c6893491497021082(create.js)
>
> Lorin's commit led to errors 2-5.  The remainder are the result of Josh's
> commits.
>
> The text of the failed tests:
>
> 1) hooker should throw if provided directory is not a cordova project
>    Message:
>       [31mExpected function to throw Not a Cordova project, can't use hooks. , but it
threw Not a Cordova project ("/var/folders/p5/b_w_jqzj2jd64nz22dnv7xzc0000gn/T/e2e-test/hooks_test"),
can't use hooks. [0m
>    Stacktrace:
>      Error: Expected function to throw Not a Cordova project, can't use hooks. , but
it threw Not a Cordova project ("/var/folders/p5/b_w_jqzj2jd64nz22dnv7xzc0000gn/T/e2e-test/hooks_test"),
can't use hooks.
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/e2e/hooker.spec.js:53:12)
>
>   2) create command callback should return null if a callback parameter is used
>    Message:
>       [31mReferenceError: foobar is not defined [0m
>    Stacktrace:
>      ReferenceError: foobar is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/create.spec.js:79:66)
>
>   3) create command callback should return null if a callback parameter is used
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for something to happen [0m
>    Stacktrace:
>      undefined
>
>   4) create command callback should call the callback function if callback parameter
is used
>    Message:
>       [31mReferenceError: foobar is not defined [0m
>    Stacktrace:
>      ReferenceError: foobar is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/create.spec.js:79:66)
>
>   5) create command callback should call the callback function if callback parameter
is used
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for something to happen [0m
>    Stacktrace:
>      undefined
>
>   6) create command success should create top-level directory structure appropriate for
a cordova-cli project
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for spec to complete [0m
>    Stacktrace:
>      undefined
>
>   7) create command success should create hooks directory
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for spec to complete [0m
>    Stacktrace:
>      undefined
>
>   8) create command success should by default use cordova-app-hello-world as www assets
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for spec to complete [0m
>    Stacktrace:
>      undefined
>
>   9) create command success should try to lazy load custom www location if specified
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for spec to complete [0m
>    Stacktrace:
>      undefined
>
>   10) create command success should add a missing www/config.xml
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for spec to complete [0m
>    Stacktrace:
>      undefined
>
>   11) create command success should not replace an existing www/config.xml
>    Message:
>       [31mtimeout: timed out after 10000 msec waiting for spec to complete [0m
>    Stacktrace:
>      undefined
>
>   12) android project parser constructions should throw if provided directory does not
contain an AndroidManifest.xml
>    Message:
>       [31mExpected function to throw The provided path "some/path" is not an Android
project. , but it threw CordovaError is not defined [0m
>    Stacktrace:
>      Error: Expected function to throw The provided path "some/path" is not an Android
project. , but it threw CordovaError is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/android_parser.spec.js:71:16)
>
>   13) blackberry10 project parser constructions should throw an exception with a path
that is not a native blackberry project
>    Message:
>       [31mExpected function to throw The provided path "/some/path" is not a Cordova
BlackBerry10 project. , but it threw CordovaError is not defined [0m
>    Stacktrace:
>      Error: Expected function to throw The provided path "/some/path" is not a Cordova
BlackBerry10 project. , but it threw CordovaError is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/blackberry_parser.spec.js:85:16)
>
>   14) blackberry10 project parser check_requirements should fire a callback if the blackberry-deploy
shell-out fails
>    Message:
>       [31mReferenceError: CordovaError is not defined [0m
>    Stacktrace:
>      ReferenceError: CordovaError is not defined
>     at /Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/blackberry10_parser.js:50:26
>     at Object.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/blackberry_parser.spec.js:99:29)
>     at Function.module.exports.check_requirements (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/blackberry10_parser.js:48:19)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/blackberry_parser.spec.js:101:56)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/async-callback.js:45:37)
>
>   15) ios project parser constructions should throw if provided directory does not contain
an xcodeproj file
>    Message:
>       [31mExpected function to throw The provided path is not a Cordova iOS project.
, but it threw CordovaError is not defined [0m
>    Stacktrace:
>      Error: Expected function to throw The provided path is not a Cordova iOS project.
, but it threw CordovaError is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/ios_parser.spec.js:60:16)
>
>   16) windows8 project parser constructions should throw if provided directory does not
contain a jsproj file
>    Message:
>       [31mExpected function to throw The provided path "/some/path" is not a Windows
8 project. Error: No .jsproj file. , but it threw CordovaError is not defined [0m
>    Stacktrace:
>      Error: Expected function to throw The provided path "/some/path" is not a Windows
8 project. Error: No .jsproj file. , but it threw CordovaError is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/windows8_parser.spec.js:72:16)
>
>   17) windows8 project parser check_requirements should fire a callback if there is an
error during shelling out
>    Message:
>       [31mReferenceError: CordovaError is not defined [0m
>    Stacktrace:
>      ReferenceError: CordovaError is not defined
>     at /Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/windows8_parser.js:64:26
>     at Object.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/windows8_parser.spec.js:87:17)
>     at Function.module.exports.check_requirements (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/windows8_parser.js:61:19)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/windows8_parser.spec.js:89:52)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/async-callback.js:45:37)
>
>   18) wp7 project parser constructions should throw if provided directory does not contain
a csproj file
>    Message:
>       [31mExpected function to throw The provided path "/some/path" is not a Windows
Phone 7 project. Error: No .csproj file. , but it threw CordovaError is not defined [0m
>    Stacktrace:
>      Error: Expected function to throw The provided path "/some/path" is not a Windows
Phone 7 project. Error: No .csproj file. , but it threw CordovaError is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/wp7_parser.spec.js:78:16)
>
>   19) wp7 project parser check_requirements should fire a callback if there is an error
during shelling out
>    Message:
>       [31mReferenceError: CordovaError is not defined [0m
>    Stacktrace:
>      ReferenceError: CordovaError is not defined
>     at /Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/wp7_parser.js:60:26
>     at Object.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/wp7_parser.spec.js:92:29)
>     at Function.module.exports.check_requirements (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/wp7_parser.js:57:19)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/wp7_parser.spec.js:94:47)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/async-callback.js:45:37)
>
>   20) wp8 project parser constructions should throw if provided directory does not contain
a csproj file
>    Message:
>       [31mExpected function to throw The provided path "/some/path" is not a Windows
Phone 8 project. Error: No .csproj file. , but it threw CordovaError is not defined [0m
>    Stacktrace:
>      Error: Expected function to throw The provided path "/some/path" is not a Windows
Phone 8 project. Error: No .csproj file. , but it threw CordovaError is not defined
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/wp8_parser.spec.js:78:16)
>
>   21) wp8 project parser check_requirements should fire a callback if there is an error
during shelling out
>    Message:
>       [31mReferenceError: CordovaError is not defined [0m
>    Stacktrace:
>      ReferenceError: CordovaError is not defined
>     at /Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/wp8_parser.js:60:26
>     at Object.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/wp8_parser.spec.js:92:29)
>     at Function.module.exports.check_requirements (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/src/metadata/wp8_parser.js:57:19)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/spec/metadata/wp8_parser.spec.js:94:47)
>     at null.<anonymous> (/Users/medic/buildbot/slave_common/Tools_CLI/build/cordova-cli/node_modules/jasmine-node/lib/jasmine-node/async-callback.js:45:37)
>
> Please take a look when you have a moment.
>
> Thanks!
> -Max
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message