cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From torrmal <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....
Date Thu, 27 Mar 2014 15:26:44 GMT
Github user torrmal commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38818105
  
    Hi Ian,
    My apologies, I a very sorry about this.
    
     how do I run the tests?
    
    I think I found where the error is, when aboirt is called in the test the download delegate
has not yet been added to the activeTransfers queue. I think it can be fixed this by just
sending the delegate start to a new thread.  in:
    https://github.com/torrmal/cordova-plugin-file-transfer/commit/44cb8008dac82a4505ea6bb59e893df2457529a1
    
    Let me know if it works, and once I learn how to run the tests I will make sure this does
not happen again,
    
    Jorge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message