cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gabrielschulhof <...@git.apache.org>
Subject [GitHub] cordova-plugman pull request: Add platform support for tizen
Date Thu, 27 Mar 2014 08:30:52 GMT
Github user gabrielschulhof commented on a diff in the pull request:

    https://github.com/apache/cordova-plugman/pull/67#discussion_r11013640
  
    --- Diff: package.json ---
    @@ -34,6 +34,7 @@
         "request": "2.22.0"
       },
       "devDependencies": {
    +    "temp": "0.6.x",
    --- End diff --
    
    Actually, blackberry10 also creates a temporary directory, but it does so less securely,
because it [uses](https://github.com/apache/cordova-plugman/blob/97fa482d0c403209336b8eb51096cfe6d4df82b6/spec/platforms/blackberry10.spec.js#L9)
    ```JS
    temp = path.join(os.tmpdir(), 'plugman'),
    ```
    Creating a proper, guaranteed-unique temporary directory is a better idea, but whatever
...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message