cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imhotep <...@git.apache.org>
Subject [GitHub] cordova-plugman pull request: Add platform support for tizen
Date Wed, 26 Mar 2014 23:14:06 GMT
Github user imhotep commented on a diff in the pull request:

    https://github.com/apache/cordova-plugman/pull/67#discussion_r11004412
  
    --- Diff: src/platforms/tizen.js ---
    @@ -0,0 +1,14 @@
    +var path = require('path')
    +    , xml_helpers = require('../util/xml-helpers')
    +    , common = require('./common');
    +
    +module.exports = {
    +    www_dir: function(project_dir) {
    +        return path.join(project_dir, 'www');
    +    },
    +    package_name:function(project_dir) {
    +        var config_path = path.join(module.exports.www_dir(project_dir), 'config.xml');
    +        var widget_doc = xml_helpers.parseElementtreeSync(config_path);
    +        return widget_doc._root.attrib['id'];
    +    }
    --- End diff --
    
    I am pretty sure I commented on this in your previous pull request #44 (as well as on
the mailing list) but I will try again and hopefully it sticks around. So:
    You are required to implement a handler for each file type with install/uninstall methods/properties.
That is: source-file, header-file, lib-file etc...even if they don't do anything. At the very
minimum source-file is required. I am not exactly sure what www_dir and package_name actually
help with plugin installation and uninstallation. Please take a look at how blackberry10,
firefoxos do it for example. Otherwise spec/platform.spec.js fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message