cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: Add platform tizen
Date Wed, 26 Mar 2014 17:15:21 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/125#discussion_r10987117
  
    --- Diff: package.json ---
    @@ -44,6 +44,7 @@
       },
       "devDependencies": {
         "jasmine-node": "1.13.x"
    +    "temp": "0.6.x"
    --- End diff --
    
    While a dependency for tempdirs is interesting, I don't think this is the style of tests
that CLI is trying to host.
    
    They're basically proscriptive as opposed to actually verifying output.
    
    I'm hoping to eventually convert CLI tests to use a synthetic file system so that we can
remove the Spy() junk and just let the synthetic file system handle file create/write/modify/read/delete
(although it's a bit of a pipe dream).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message