cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bryanhiggins <...@git.apache.org>
Subject [GitHub] cordova-blackberry pull request: CB-6326 (cordova-blackberry) targ...
Date Sun, 23 Mar 2014 16:31:03 GMT
Github user bryanhiggins commented on the pull request:

    https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38387520
  
    Thanks a lot for pointing this out. When manually adding a simulator using the "blackberry10/bin/target
add" command, it is added with "simulator", but the simulator detection logic in run-utils.js
is using "emulator".
    
    I'm fine with making "emulator" the default in blackberry10.json. 
    
    Please checkout my commit below which is an addition to yours. I believe it covers all
use cases, including fixing older files.
    
    https://github.com/blackberry/cordova-blackberry/commit/7b563950c1c2612838b37d81c906f286384ae0bc



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message