cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clelland <>
Subject [GitHub] cordova-android pull request: Allow subdomains flag in Whitelist x...
Date Wed, 19 Mar 2014 19:58:59 GMT
Github user clelland commented on a diff in the pull request:
    --- Diff: framework/src/org/apache/cordova/ ---
    @@ -136,6 +136,14 @@ public void addWhiteListEntry(String origin, boolean subdomains)
                             } else {
                                 whiteList.add(new URLPattern(scheme, host, port, path));
    +                        if( subdomains ){
    --- End diff --
    This should probably also check `!host.startsWith("*.")`, to avoid accidentally generating
patterns like `*.*`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message