cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gabrielschulhof <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: CB-6299 Strip protocol and leading slash...
Date Wed, 19 Mar 2014 14:42:20 GMT
Github user gabrielschulhof commented on the pull request:

    https://github.com/apache/cordova-wp8/pull/30#issuecomment-38058149
  
    So, there are (probably more than) three cases when retrieving a local file via Ajax:
    <dl>
    <dt><code>other-file.html</code></dt><dd>works, because
the URL is correctly assembled by Cordova</dd>
    <dt><code>x-wmapp0:www/other-file.html</code></dt><dd>works,
because the Uri class used <a href="https://github.com/apache/cordova-wp8/blob/0f80d8802ce846f062d7bc343a0e46534bdbc7a9/wp8/template/cordovalib/XHRHelper.cs#L243">here</a>
seems to understand this kind of URL</dd>
    <dt><code>x-wmapp0:/www/other-file.html</code></dt><dd>doesn't
work, because the <a href="https://github.com/apache/cordova-wp8/blob/0f80d8802ce846f062d7bc343a0e46534bdbc7a9/wp8/template/cordovalib/XHRHelper.cs#L194-L205">code</a>
I mention in my previous comment is not having an effect due to the fact that the URL starts
with the protocol</dd>
    </dl>
    
    Now, granted, the form ```x-wmapp0:/www/other.html``` may not occur much in the wild,
but performing URL calculations such as creating an absolute URL from a relative URL are impossible
when the URL scheme does not have a slash at the root, because you cannot distinguish an absolute
URL from a relative URL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message