cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gabrielschulhof <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: CB-6299 Strip protocol and leading slash...
Date Wed, 19 Mar 2014 14:32:29 GMT
Github user gabrielschulhof commented on the pull request:

    https://github.com/apache/cordova-wp8/pull/30#issuecomment-38056875
  
    That does indeed work. What doesn't work is ```x-wmapp0:/www/some-other-file.html```.
The leading slash is causing a 404. Basically, [this](https://github.com/apache/cordova-wp8/blob/0f80d8802ce846f062d7bc343a0e46534bdbc7a9/wp8/template/cordovalib/XHRHelper.cs#L194-L205)
code is only useful if you have absolute URLs that do not include the protocol. If the URL
includes the protocol, then all that code is bypassed. My modification would first strip off
the protocol so that code can do its magic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message