cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mparpaillon <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage
Date Tue, 18 Mar 2014 23:11:33 GMT
Github user mparpaillon commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-38000539
  
    The "isOrientationLocked" didn't seem useful because only the iPad needs a landscape or
portrait splashscreen. So the condition "CDV_IsIPad()" should be enough.
    
    If something else than an iPad enters this condition then the app will search for splashscreens
with "-landscape" and "-portrait" at the end (which is irrelevant for iPhones)
    
    I guess the "&&" operator makes more sense indeed. We just need to be sure iPhones
don't enter this condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message