cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror
Date Mon, 10 Mar 2014 18:17:50 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-app-hello-world/pull/6#discussion_r10442330
  
    --- Diff: www/index.html ---
    @@ -37,6 +37,8 @@
             <script type="text/javascript" src="cordova.js"></script>
             <script type="text/javascript" src="js/index.js"></script>
             <script type="text/javascript">
    +            window.onerror = function (errorMsg, url, lineNumber) { alert("ERROR:" +
errorMsg + ", " + url + ":" + lineNumber); };
    --- End diff --
    
    I'm not a fan of onerror -> alert() ... Anyone creating something which triggers an
error on a timer is going to create a bunch of dialogs and that's a bad approach.
    
    I'm generally encouraging console.log( object-map )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message