Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: "Naik, Archana" <naika@lab126.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: Re: Android/amazon-fireos: web view callbacks
Thread-Topic: Android/amazon-fireos: web view callbacks
Thread-Index: AQHPId4ZjOP3bfTcJ02uIe36j4P6m5qmARUA//+F/QA=
Date: Tue, 4 Feb 2014 20:12:19 +0000
Message-ID: <CF16890D.E82F%naika@amazon.com>
References: <CF167D5F.E828%naika@amazon.com>
 <CAOBL_k6AxXaLehvJUq9y_SX3OmCcdtgPMcESP3Ctms7dzmAO5g@mail.gmail.com>
In-Reply-To: 
 <CAOBL_k6AxXaLehvJUq9y_SX3OmCcdtgPMcESP3Ctms7dzmAO5g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.9.131030
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2922E220A539214691D5D22551FD506B@ant.amazon.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

So for example, onCreateWindow() or onProgressChanged(). We might need to
add onCreateWindow() but onProgressChanged() not that urgent.

More importantly, we want to let plugins handle there callbacks first and
incase they don't we want to fallback on default handlers in these classes.

Archana

On 2/4/14 11:29 AM, "Joe Bowser" <bowserj@gmail.com> wrote:

>Which callbacks in particular are missing? There are some callbacks we
>don't touch because they can break the WebView.  These can include
>anything that handles gestures (which when done wrong, can break touch
>events), and other view related callbacks.  I'd highly recommend
>writing tests for the existing behaviour before adding the callbacks,
>since we've had very bad luck with this in the past w.r.t. the back
>button.
>
>On Tue, Feb 4, 2014 at 11:20 AM, Naik, Archana <naika@lab126.com> wrote:
>> Hi, Devs
>>
>> There are 2 classes - CordovaWebViewClient and CordovaChromeClient in
>>amazon-fireos repo. They basically handle WebView callbacks. Recently,
>>while using Cordova internally for our projects we needed to handle few
>>more callbacks and noticed they were missing. I was wondering if there
>>is any reason why some callbacks were not handled? If not, I am cool.
>> I would like to add the ones we need for now so want to make sure I am
>>not missing anything. :)
>>
>> Also, one more thing, we would like to pass on these callbacks to
>>plugins incase they want to handle it. If no plugin wants handle it then
>>callback handling will fallback to the default cordova one.
>>
>> Please let me know your thoughts.
>> Thanks
>> Archana