Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC8EA108F4 for ; Tue, 25 Feb 2014 23:51:05 +0000 (UTC) Received: (qmail 14398 invoked by uid 500); 25 Feb 2014 23:51:05 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 14360 invoked by uid 500); 25 Feb 2014 23:51:04 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 14352 invoked by uid 99); 25 Feb 2014 23:51:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 23:51:04 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of anis.kadri@gmail.com designates 209.85.192.169 as permitted sender) Received: from [209.85.192.169] (HELO mail-pd0-f169.google.com) (209.85.192.169) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 23:50:58 +0000 Received: by mail-pd0-f169.google.com with SMTP id v10so137811pde.14 for ; Tue, 25 Feb 2014 15:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=uEL3a2AVj5d2wVMjNvmC+tOF/GD3Nf2hcrwZb5W5yjw=; b=G1vJYsS3lkzw3RGKqoKpeCvUxp8xsRfx/3k1+lnLqRe0OCCVJTZtycesTyWNlNwMoJ M5Fz9uoWj/pmJz1Mz4EpRmlq7lPQKxI5E05M0XG5gRJrtC/HdxIVL54SC8VHnZ7OdKRd I6O1BV5MltoH9J42dK17z9mohWgnHB3D+qoJ2ZBQX+AGiOJ0ccOpVqfuwNFE8FlgFQ0a rSG+UjK0wictekb+5AFVjFu5/8mJI9F59DIhDlX7GmeDeXi/9R0Uo6DWH6PaRKYhS4sk UtKKJVXfQ5GpQHztVHpwxBpfA3O5D8hx3A+Y9Je+HbqcQgKKD5X6LXA5MwhwVUxBex9q M/Vw== MIME-Version: 1.0 X-Received: by 10.68.131.100 with SMTP id ol4mr2768203pbb.134.1393372237713; Tue, 25 Feb 2014 15:50:37 -0800 (PST) Received: by 10.66.144.165 with HTTP; Tue, 25 Feb 2014 15:50:37 -0800 (PST) In-Reply-To: References:

Date: Tue, 25 Feb 2014 15:50:37 -0800 Message-ID: Subject: Re: Framework support via plugman + plugin spec From: Anis KADRI To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=047d7b15ae9b44d87904f343c1a9 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b15ae9b44d87904f343c1a9 Content-Type: text/plain; charset=ISO-8859-1 Forgot to mention that there is also a for pre-compiled libraries. On Tue, Feb 25, 2014 at 3:49 PM, Anis KADRI wrote: > Both types are installable by plugman. > > The (install.js) code does not give you a full picture. > > Take a look at [1] > > It is not a defect. > > For tool that is just supposed to moves file around and update some config > files, I think plugman has gotten overly complicated. Mostly to meet CLI > requirements. > > [1] > https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=blob;f=src/util/config-changes.js;h=989a582649732469921c80d4ede6f9f00874d3ea;hb=HEAD#l130 > > > On Tue, Feb 25, 2014 at 2:58 PM, Jesse wrote: > >> Inline ... >> >> @purplecabbage >> risingj.com >> >> >> On Tue, Feb 25, 2014 at 2:49 PM, Anis KADRI wrote: >> >> > 1. This is an iOS only thing. Non-custom means System frameworks that >> ship >> > with the iOS SDK (CoreGraphics.framework, Accounts.frameworks, ...). >> Custom >> > frameworks are the ones you usually download, drag and drop to your >> xcode >> > project. There are some differences in how the project is structured for >> > System vs Custom frameworks. >> > >> >> Well, the framework tag now applies to Windows Phone and Windows 8, so >> this >> needs to be addressed. >> I understand the difference between custom and not-custom, but I require >> both types to be install-able by plugman. >> ie. custom means copy lib file to project + add linker reference >> not-custom means just add linker reference >> >> >> > 2. It is silly I know but I didn't want to introduce a new tag. >> Especially >> > since there was already one that was >> > explicit enough (the tag). >> > >> >> Not silly, I too want to use the framework tag ... >> >> >> > >> > 3. if unspecified or set to false, it will be considered as a system >> > framework. Otherwise (if custom="true") it is considered a custom >> framework >> > and the xcode project will be structured accordingly. We could make the >> > custom attribute mandatory but I thought it would more of a pain. >> Besides, >> > it would break existing plugins that use System Frameworks. >> > >> >> Looking at the code any framework tag that does not have @custom='true' >> will be completely ignored. Is this a defect? >> >> >> > >> > Anis >> > >> > >> > On Tue, Feb 25, 2014 at 2:35 PM, Jesse wrote: >> > >> > > Plugman's install.js has this nice little gem in the source [0]: >> > > >> > > frameworkFiles = platformTag.findall('./framework[@custom="true"]'), >> // >> > > CB-5238 adding only custom frameworks >> > > >> > > Looking through CB-5238[1], and the related issues [2][3] I have some >> > > questions. >> > > >> > > 1. How do we add a non-custom framework? >> > > 2. What is the point of having an attribute that we only accept one >> value >> > > for? >> > > 3. The docs [4] state that the default is false, but the code does >> not do >> > > anything unless @custom is 'true', where is the disconnect? >> > > >> > > [0] >> > > >> > >> https://github.com/apache/cordova-plugman/blob/master/src/install.js#L362 >> > > [1] https://issues.apache.org/jira/browse/CB-5238 >> > > [2] https://issues.apache.org/jira/browse/CB-5682 >> > > [3] https://issues.apache.org/jira/browse/CB-5949 >> > > [4] http://cordova.apache.org/docs/en/edge/plugin_ref_spec.md >> > > >> > > >> > > >> > > @purplecabbage >> > > risingj.com >> > > >> > >> > > --047d7b15ae9b44d87904f343c1a9--