Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of iclelland@google.com designates
 209.85.214.178 as permitted sender)
MIME-Version: 1.0
Sender: iclelland@google.com
In-Reply-To: 
 <CAAS6=7i2ACM2PUVYfC36GZFQwBDtXau8bfsJkDXRCUBupM5ksg@mail.gmail.com>
References: 
 <CAAS6=7i2ACM2PUVYfC36GZFQwBDtXau8bfsJkDXRCUBupM5ksg@mail.gmail.com>
From: Ian Clelland <iclelland@chromium.org>
Date: Wed, 26 Feb 2014 13:51:56 -0500
Message-ID: 
 <CAK_TSXK8aqzpV7iu7wo+3i+BqLL0cK5AGt1-zE6M8ULqhfg9vw@mail.gmail.com>
Subject: Re: [VOTE][DISCUSS] Cordova 3.1.0
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=047d7b5d5c7217860c04f353b408

--047d7b5d5c7217860c04f353b408
Content-Type: text/plain; charset=UTF-8

Thanks for the clarification, Marvin.

I've created https://issues.apache.org/jira/browse/CB-6113 to track this
for the next release.


On Wed, Feb 26, 2014 at 1:21 PM, Marvin Humphrey <marvin@rectangular.com>wrote:

> On Wed, Feb 26, 2014 at 9:27 AM, Ian Clelland <iclelland@chromium.org>
> wrote:
> > I'm not sure about the lack of a NOTICE file; it otherwise indicates
> > "This product includes software developed by
> > Google Code Prettify (http://code.google.com/p/google-code-prettify)"
> > which isn't covered by the cordova-3.1.0/NOTIFY file
>
> Comparing the contents of 3.0.0 to 3.1.0, it seems that prettify is in one
> of
> the directories that happened to be stripped
> (cordova-docs/template/docs/default/prettify).  Since those bits aren't
> bundled, there's no need to mention anything in LICENSE/NOTICE.
>
> So there's no problem here that would affect the 3.1.0 release.
>
> Actually, looking at google-code-prettify's licensing, both the bundled
> version and the current upstream, they don't include a NOTICE file -- so
> mentioning them in cordova-docs/NOTICE is actually a minor licensing
> documentation bug.  (NOTICE should only include stuff that's absolutely
> necessary, so that it's easier for downstream users to consume.)  I'd
> suggest
> applying the patch below to cordova-docs.
>
> Cheers,
>
> Marvin Humphrey
>
> --- NOTICE.orig 2014-02-26 10:12:04.000000000 -0800
> +++ NOTICE 2014-02-26 10:12:13.000000000 -0800
> @@ -4,5 +4,3 @@
>  This product includes software developed by
>  The Apache Software Foundation (http://www.apache.org)
>
> -This product includes software developed by
> -Google Code Prettify (http://code.google.com/p/google-code-prettify)
>

--047d7b5d5c7217860c04f353b408--